duongkame commented on PR #4194: URL: https://github.com/apache/ozone/pull/4194#issuecomment-1409846648
> @duongkame thank you for working on this one, the code and the structure of the code looks well thought out. > > As we discussed with @jojochuang we should not use Serializable, instead we probably should serialize and deserialize the things with protobuf as we do in other parts of the code. > > Besides this please find my comments inline. Thanks for the review @fapifta. I visited all the comments and took action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
