siddhantsangwan opened a new pull request, #4227: URL: https://github.com/apache/ozone/pull/4227
## What changes were proposed in this pull request? Check the jira for a description of the task: https://issues.apache.org/jira/browse/HDDS-7847 Legacy RM calls mismatched and UNHEALTHY replicas unhealthy. New RM calls only UNHEALTHY replicas unhealthy. Some notes about the changes proposed here: 1. Legacy RM tries to close all replicas, even UNHEALTHY ones. We don’t do this in RM - No need? 2. Legacy RM currently does not handle mis replication when ALL replicas are unhealthy. New RM will not either. 3. Legacy tries to close a quasi closed replica of a closed container, while new RM doesn't. We need to add this to MismatchedReplicasHandler but this is not done in this pr. 4. Legacy tries to close a quasi closed replica of a quasi closed container in some cases. This is probably a bug and is not done in new RM. 5. If a container is over rep with mismatched replicas, it will not be queued to over rep queue in the new RM. We need an improvement jira that tries to enqueue such a container if there is sufficient replication when considering only matching replicas. For example, for a CLOSED container with replicas {CLOSED, CLOSED, CLOSED, OPEN, UNHEALTHY}. `RatisReplicationCheckHandler` will not queue this. Check `testOverReplicatedContainerWithMismatchedReplicas`. Legacy will try to close the open replica and delete the UNHEALTHY one in `handleOverReplicatedExcessUnhealthy`. Whereas RM will only try to close the OPEN replica. ## How was this patch tested? Added UTs. Still need to add some in `TestReplicationManager`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
