neils-dev commented on PR #3741: URL: https://github.com/apache/ozone/pull/3741#issuecomment-1411337922
In the `KeyValueHandler.importContainerData`, it too tries to cleanup the container should the import fail through container delete. This would be a good candidate for the container _move_ to `tmp` directory and delete to ensure no artifacts are left in case the delete fails. https://github.com/apache/ozone/blob/6389d01605053a9a5ae5510b67fb2bc6204db9d2/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java#L560 @errose28 , is this what you had in mind for reusing the `tmp dir` and cleanup for the volume? In this case should the container import fails, it would move the container to the `tmp `directory, try to delete from db. In the event of failure it should be picked up by the cleanup on datanode shutdown/start and retried. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
