sodonnel commented on code in PR #4228:
URL: https://github.com/apache/ozone/pull/4228#discussion_r1092975416
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/IncrementalContainerReportHandler.java:
##########
@@ -91,6 +91,8 @@ public void onMessage(final
IncrementalContainerReportFromDatanode report,
if (!replicaProto.getState().equals(
ContainerReplicaProto.State.DELETED)) {
nodeManager.addContainer(dd, id);
+ } else {
Review Comment:
I did originally have an `else(DELETED)` statement, but then I realized the
IF part is for "not deleted", so else can only be deleted. It may be safer for
the future to make it an `else if`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
