chrisGe123 commented on code in PR #3997:
URL: https://github.com/apache/ozone/pull/3997#discussion_r1093912270
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -668,13 +668,21 @@ public void createBucket(
builder.setDefaultReplicationConfig(defaultReplicationConfig);
}
+ String replicationType = defaultReplicationConfig == null
+ ? "with server-side default replication type"
+ : defaultReplicationConfig.getType().toString();
+
String layoutMsg = bucketLayout != null
? "with bucket layout " + bucketLayout
: "with server-side default bucket layout";
LOG.info("Creating Bucket: {}/{}, {}, {} as owner, Versioning {}, " +
- "Storage Type set to {} and Encryption set to {} ",
+ "Storage Type set to {} and Encryption set to {}, " +
+ "Replication Type set to {}, Namespace Quota set to {}, " +
Review Comment:
@DaveTeng0 and @adoroszlai I am still waiting for Sammi to come back from
holidays to help me out about github issue, but you guys can help me to review
the test result as followed to see if this message change is ok:
```
# bin/ozone sh bucket create /vol1/bucket2 --layout FILE_SYSTEM_OPTIMIZED
--type EC --replication rs-3-2-1024k
23/01/19 07:53:18 INFO rpc.RpcClient: Creating Bucket: vol1/bucket2, with
bucket layout FILE_SYSTEM_OPTIMIZED, root as owner, Versioning false, Storage
Type set to DISK and Encryption set to false, Replication Config is set to
EC/ECReplicationConfig{data=3, parity=2, ecChunkSize=1048576, codec=rs}, Counts
Quota set to -1, Space Quota set to -1 bytes
# bin/ozone sh bucket create /vol1/bucket3
23/01/19 07:54:33 INFO rpc.RpcClient: Creating Bucket: vol1/bucket3, with
server-side default bucket layout, root as owner, Versioning false, Storage
Type set to DISK and Encryption set to false, Replication Config is set to
server-side default replication config, Counts Quota set to -1, Space Quota set
to -1 bytes
# bin/ozone sh bucket create /vol1/bucket3 --layout OBJECT_STORE
--replication-type EC --replication rs-6-3-1024k --namespace-quota=10
--space-quota=1073741824
23/01/19 07:55:27 INFO rpc.RpcClient: Creating Bucket: vol1/bucket3, with
bucket layout OBJECT_STORE, root as owner, Versioning false, Storage Type set
to DISK and Encryption set to false, Replication Config is set to
EC/ECReplicationConfig{data=6, parity=3, ecChunkSize=1048576, codec=rs}, Counts
Quota set to 10, Space Quota set to 1073741824 bytes
BUCKET_ALREADY_EXISTS Bucket already exist
# bin/ozone sh bucket create /vol1/bucket4 --layout OBJECT_STORE
--replication-type EC --replication rs-6-3-1024k --namespace-quota=10
--space-quota=1073741824
23/01/19 07:55:48 INFO rpc.RpcClient: Creating Bucket: vol1/bucket4, with
bucket layout OBJECT_STORE, root as owner, Versioning false, Storage Type set
to DISK and Encryption set to false, Replication Config is set to
EC/ECReplicationConfig{data=6, parity=3, ecChunkSize=1048576, codec=rs}, Counts
Quota set to 10, Space Quota set to 1073741824 bytes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
