kaijchen commented on code in PR #4128:
URL: https://github.com/apache/ozone/pull/4128#discussion_r1098536391


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisHelper.java:
##########
@@ -488,4 +490,64 @@ public static void debug(ByteBuf buf, String name, Logger 
log) {
     }
     log.debug("{}: {}\n  {}", name, buf, builder);
   }
+
+
+  /**
+   * Use raft client to send admin request, transfer the leadership.
+   * 1. Set priority and send setConfiguration request

Review Comment:
   I would suggest don't use priority to initiate transfer leadership.
   Because in the next release of Ratis, we should be able to transfer 
leadership between nodes with same priority, see RATIS-1762 (however transfer 
to lower priority peer is still not allowed). So this interface won't disrupt 
the priority configurations.
   Otherwise this interface will be deprecated soon, just like RATIS-1769.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to