hemantk-12 commented on code in PR #4236:
URL: https://github.com/apache/ozone/pull/4236#discussion_r1099365528
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestKeyManagerImpl.java:
##########
@@ -1351,6 +1353,80 @@ public void testGetFileStatusWithFakeDir() throws
IOException {
Assert.assertTrue(ozoneFileStatus.isFile());
}
+ @Test
+ public void testGetFileStatusWithFakeDirFalsePositive() throws IOException {
Review Comment:
Hi @adoroszlai,
As @smengcl , said I agree that it is not a good idea to mix bug fix and
refactoring. But if you look at the original patch, these are the new tests
which were added and I asked them to be in Junit-5. There was no change or
refactoring to the existing code. Yes, we needed to change some imports, but I
think that's ok and not a refactoring.
Now we have duplicate imports
[BeforeClass/BeforeAll](https://github.com/apache/ozone/pull/4236/files#diff-4275d85bf442cb352596248ced7651fcd5e3b09876bb6d2d80464cdf628a23fdR184-R185),
[AfterClass/AfterAll](https://github.com/apache/ozone/pull/4236/files#diff-4275d85bf442cb352596248ced7651fcd5e3b09876bb6d2d80464cdf628a23fdR244-R245)
and
[Test](https://github.com/apache/ozone/pull/4236/files#diff-4275d85bf442cb352596248ced7651fcd5e3b09876bb6d2d80464cdf628a23fdR126).
```
@BeforeClass
@BeforeAll
```
and
```
@AfterClass
@AfterAll
```
If you think that having duplicate imports (the current situation) and clean
up is not needed is ok, I'm fine you merging it.
Also if we don't do these type of update/upgrade one by one, we will never
upgrade existing stuff unless we are forced which is rare in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
