adoroszlai commented on code in PR #4257:
URL: https://github.com/apache/ozone/pull/4257#discussion_r1099826874
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestKeyManagerImpl.java:
##########
@@ -638,8 +633,6 @@ public void testInvalidPrefixAcl() throws IOException {
.build();
// add acl with invalid prefix name
- exception.expect(OMException.class);
- exception.expectMessage("Invalid prefix name");
writeClient.addAcl(ozInvalidPrefix, ozAcl1);
Review Comment:
Isn't this (and `setAcl`, `removeAcl`) expected to throw exception? I see
the test passes as is, but why? Are these writes no-ops in the test? If so, I
think we should remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
