adoroszlai commented on code in PR #3943:
URL: https://github.com/apache/ozone/pull/3943#discussion_r1101847156
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/conf/StorageContainerManagersCommandHandler.java:
##########
@@ -29,7 +29,7 @@
* Handler for ozone getconf storagecontainermanagers.
*/
@Command(name = "storagecontainermanagers",
- aliases = {"-storagecontainermanagers"},
+ aliases = {"-storagecontainermanagers", "--storage-container-managers"},
Review Comment:
Same here.
```suggestion
aliases = {"-storagecontainermanagers"},
```
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/conf/OzoneManagersCommandHandler.java:
##########
@@ -28,7 +28,7 @@
* Handler for ozone getconf ozonemanagers.
*/
@Command(name = "ozonemanagers",
- aliases = {"-ozonemanagers"},
+ aliases = {"-ozonemanagers", "--ozone-managers"},
Review Comment:
`-ozonemanagers` here is not an option, rather an alias for the command name
(`ozonemanagers`). I think we should omit the new alias.
```suggestion
aliases = {"-ozonemanagers"},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
