symious commented on code in PR #3874: URL: https://github.com/apache/ozone/pull/3874#discussion_r1103826163
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerServiceMetrics.java: ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.diskbalancer; + +import org.apache.hadoop.metrics2.MetricsSystem; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.MutableCounterLong; + +/** + * Metrics related to DiskBalancer Service running on Datanode. + */ +@Metrics(name = "DiskBalancerService Metrics", about = "Metrics related to " + + "background disk balancer service on Datanode", context = "dfs") +public final class DiskBalancerServiceMetrics { + + private static DiskBalancerServiceMetrics instance; + public static final String SOURCE_NAME = + DiskBalancerServiceMetrics.class.getSimpleName(); + + @Metric(about = "The number of successful balance job") + private MutableCounterLong successCount; + + @Metric(about = "The total bytes for successfully balanced job.") + private MutableCounterLong successBytes; + + @Metric(about = "The number of failed balance job.") + private MutableCounterLong failureCount; + + @Metric(about = "The number of total running loop") + private MutableCounterLong runningLoopCount; + + @Metric(about = "The number of idle loop that can not generate volume pair.") + private MutableCounterLong idleLoopNoAvailableVolumePairCount; + + @Metric(about = "The number of idle loop due to bandwidth limits.") + private MutableCounterLong idleLoopExceedsBandwidthCount; + + private DiskBalancerServiceMetrics() { + } + + public static DiskBalancerServiceMetrics create() { + if (instance == null) { + MetricsSystem ms = DefaultMetricsSystem.instance(); + instance = ms.register(SOURCE_NAME, "DiskBalancerService", + new DiskBalancerServiceMetrics()); + } + + return instance; + } + + /** + * Unregister the metrics instance. + */ + public static void unRegister() { Review Comment: Updated, added invoke in shutdown(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
