GeorgeJahad commented on PR #4245: URL: https://github.com/apache/ozone/pull/4245#issuecomment-1430505298
Hey @ArafatKhan2198 @smengcl @dombizita: Last year, when @xBis7 and I implemented this for legacy buckets, we were going to do object store buckets as well. We didn't because @avijayanhwx (the engineer who originally created this epic), told us it would be good to support "object store prefixes". It looks like this PR still doesn't support them. Instead it just assigns all object store keys to the corresponding bucket. I'm fine with that, but just want to be sure that everyone understands it wasn't the initial intention. FYI: this is how @avijayanhwx defined the prefixes: *"What I mean as object store prefix is not dissimilar to a directory in legacy FS buckets, but there is added complexity in Recon to track them since they will not be present in the OM metadata. For example, in a pure OS bucket, the rocksdb entry would be /vol1/bucket1/application1/instance1/file1. The prefixes ( /vol1/bucket1/application1 & /vol1/bucket1/application1/instance1) are not created as keys in RocksDB. We wanted to explore how to capture them and calculate summaries at prefix levels. Feel free to think about the need to do it as well as how we could design it. Thanks for taking this up."* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
