smengcl commented on code in PR #4244:
URL: https://github.com/apache/ozone/pull/4244#discussion_r1106487869
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1691,6 +1694,18 @@ message DeleteSnapshotRequest {
optional uint64 deletionTime = 4;
}
+message SnapshotMoveDeletedKeysRequest {
+ required SnapshotInfo fromSnapshot = 1;
+ optional SnapshotInfo nextSnapshot = 2;
+ repeated KeyValuePair activeDBKeys = 3;
+ repeated KeyValuePair nextDBKeys = 4;
+}
+
+message KeyValuePair {
Review Comment:
`KeyValuePair` sounds way too generic. Name more specifically according to
its usage.
Even better, put a comment around its intended usage.
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1691,6 +1694,18 @@ message DeleteSnapshotRequest {
optional uint64 deletionTime = 4;
}
+message SnapshotMoveDeletedKeysRequest {
+ required SnapshotInfo fromSnapshot = 1;
+ optional SnapshotInfo nextSnapshot = 2;
+ repeated KeyValuePair activeDBKeys = 3;
+ repeated KeyValuePair nextDBKeys = 4;
+}
+
+message KeyValuePair {
+ required string key = 1;
Review Comment:
```suggestion
optional string key = 1;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
