GeorgeJahad commented on code in PR #4206:
URL: https://github.com/apache/ozone/pull/4206#discussion_r1106525471
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestFileSizeCountTask.java:
##########
@@ -73,45 +73,60 @@ public void setUp() {
}
@Test
- public void testReprocess() throws IOException {
- OmKeyInfo omKeyInfo1 = mock(OmKeyInfo.class);
- given(omKeyInfo1.getKeyName()).willReturn("key1");
- given(omKeyInfo1.getVolumeName()).willReturn("vol1");
- given(omKeyInfo1.getBucketName()).willReturn("bucket1");
- given(omKeyInfo1.getDataSize()).willReturn(1000L);
-
- OmKeyInfo omKeyInfo2 = mock(OmKeyInfo.class);
- given(omKeyInfo2.getKeyName()).willReturn("key2");
- given(omKeyInfo2.getVolumeName()).willReturn("vol1");
- given(omKeyInfo2.getBucketName()).willReturn("bucket1");
- given(omKeyInfo2.getDataSize()).willReturn(100000L);
-
- OmKeyInfo omKeyInfo3 = mock(OmKeyInfo.class);
- given(omKeyInfo3.getKeyName()).willReturn("key3");
- given(omKeyInfo3.getVolumeName()).willReturn("vol1");
- given(omKeyInfo3.getBucketName()).willReturn("bucket1");
- given(omKeyInfo3.getDataSize()).willReturn(1125899906842624L * 4); // 4PB
+ public void testReprocessFSO() throws IOException {
Review Comment:
Why is this test called "testReprocessFSO"? It tests both types of layouts.
After that, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
