neils-dev commented on code in PR #4044:
URL: https://github.com/apache/ozone/pull/4044#discussion_r1110430866
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/GrpcOzoneManagerServer.java:
##########
@@ -91,9 +97,15 @@ public void init(OzoneManagerProtocolServerSideTranslatorPB
omTranslator,
CertificateClient caClient) {
NettyServerBuilder nettyServerBuilder = NettyServerBuilder.forPort(port)
.maxInboundMessageSize(maxSize)
- .addService(new OzoneManagerServiceGrpc(omTranslator,
- delegationTokenMgr,
- omServerConfig));
+ .maxConnectionIdle(CLIENT_TIMEOUT_SECS, TimeUnit.SECONDS)
Review Comment:
This timeout is questionable. What is the reason for this. Offline we had
a discussion to not have a timeout. Can we remove the timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
