ArafatKhan2198 commented on PR #4266: URL: https://github.com/apache/ozone/pull/4266#issuecomment-1435919671
> The `OMDBUpdateEvent` being processed by `FileSizeCountTask` should have come from `processEvent` [here](https://github.com/apache/ozone/blob/59938f90bf035dde1285294d4103a49fb0840a8a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OMDBUpdatesHandler.java#L142-L154). > > And because `deletedTable` is the only table that [carries](https://github.com/apache/ozone/blob/1bb74438fad30c96b699bcbb7c27b695a0b7a072/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java#L555-L556) those `RepeatedOmKeyInfo` values, the correct action to take in this case could simply be **ignoring** the event when its value is of class `RepeatedOmKeyInfo`. -- Because those same keys are very likely processed once already when they are "moved" from `keyTable` to `deletedTable` during key delete request, where the former effectively [deletes](https://github.com/apache/ozone/blob/a5602a8b017384eb832da8b688323b5250d6af84/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyDeleteResponse.java#L72-L75) the entries from `keyTable`. Please double check if this is the case. CMIIW. - The deletedTable stores information about deleted keys in Ozone Manager's metadata. Whenever an object is deleted, the `OmMetadataManagerImpl` class creates an entry in the deletedTable in the form of `RepeatedOmKeyInfo` class that contains multiple `OmKeyInfo` objects with the same URI. Periodic scans by Ozone's background services identify objects eligible for permanent deletion, which are then removed from the deletedTable and their corresponding data is freed from storage. - Since this information is hidden from the user, there's no need to worry about the contents of the `deletedTable` for the fileSizeCountTask, hence we should like you suggested ignore the repeatedOmKeyInfo objects being thrown as we only deal with OmKeyInfo object from the key and file table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
