Galsza commented on code in PR #4145:
URL: https://github.com/apache/ozone/pull/4145#discussion_r1114411300
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java:
##########
@@ -111,8 +112,10 @@ public abstract class DefaultCertificateClient implements
CertificateClient {
private static final Random RANDOM = new SecureRandom();
- private static final String CERT_FILE_NAME_FORMAT = "%s.crt";
+ public static final String CERT_FILE_NAME_FORMAT = "%s.crt";
+ public static final String CA_CERT_PREFIX = "CA-";
private static final int CA_CERT_PREFIX_LEN = 3;
+ public static final String ROOT_CA_CERT_PREFIX = "ROOTCA-";
Review Comment:
On the master branch there is a CAType enum now that contains these values.
I suggest using that enum, and redefining `CA_CERT_PREFIX_LEN` as
`CAType.SUBORDINATE.getFileNamePrefix().length()` and `ROOT_CA_PREFIX_LEN` as
`CAType.ROOT.getFileNamePrefix().length()` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
