adoroszlai commented on code in PR #4316:
URL: https://github.com/apache/ozone/pull/4316#discussion_r1119257067
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java:
##########
@@ -248,5 +260,34 @@ public void testECStreamCapability() throws Exception {
assertFalse(os.hasCapability(StreamCapabilities.HSYNC),
"ECKeyOutputStream should not support hsync()!");
}
+ testEncryptedStreamCapabilities(true);
+ }
+
+ private void testEncryptedStreamCapabilities(boolean isEC) throws
IOException,
+ GeneralSecurityException {
+ KeyOutputStream kos;
+ if (isEC) {
+ kos = mock(KeyOutputStream.class);
+ } else {
+ kos = mock(ECKeyOutputStream.class);
+ }
Review Comment:
Nit: the name and meaning of `isEC` are inverse (i.e. it tests EC when
`isEC=false`). But the end result is the same, both cases are covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
