jojochuang commented on code in PR #4234:
URL: https://github.com/apache/ozone/pull/4234#discussion_r1119353505
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java:
##########
@@ -216,7 +218,17 @@ public static OMClientRequest
createClientRequest(OMRequest omRequest,
omRequest.getDeleteOpenKeysRequest().getBucketLayout());
}
return new OMOpenKeysDeleteRequest(omRequest, bktLayout);
-
+ case RecoverLease: {
+ volumeName = omRequest.getRecoverLeaseRequest().getVolumeName();
+ bucketName = omRequest.getRecoverLeaseRequest().getBucketName();
+ bucketLayout =
+ getBucketLayout(ozoneManager.getMetadataManager(), volumeName,
bucketName);
+ if (bucketLayout != BucketLayout.FILE_SYSTEM_OPTIMIZED) {
Review Comment:
No... i don't think it's a good idea to break the existing object store
semantics. No object store support a client lease recovery semantics. This is
purely meant for HDFS-like semantics for existing HDFS applications to migrate
over to Ozone, so I believe it is exclusively FSO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
