adoroszlai commented on PR #4271:
URL: https://github.com/apache/ozone/pull/4271#issuecomment-1447706645
One minor question:
> ```
> ## Full list of configs printed in all role logs :
> STARTUP_MSG: conf = {... ozone.scm.container.placement.ec.impl=
> 2023-02-27 12:45:24
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRackScatter
> 2023-02-27 12:45:24 , ozone.scm.container.placement.impl=
> 2023-02-27 12:45:24
org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementRandom
> 2023-02-27 12:45:24 , ...
ozone.scm.keyvalue.container.deletion-choosing.policy=
> 2023-02-27 12:45:24
org.apache.hadoop.ozone.container.common.impl.TopNOrderedContainerDeletionChoosingPolicy
> 2023-02-27 12:45:24 , ... ozone.scm.pipeline.leader-choose.policy=
> 2023-02-27 12:45:24
org.apache.hadoop.hdds.scm.pipeline.leader.choose.algorithms.MinLeaderCountChoosePolicy
> 2023-02-27 12:45:24 , ...}
> ```
These newlines are the result of the whitespace embedded in some config
properties' default values, e.g.:
https://github.com/apache/ozone/blob/e90e2dd8ea1770bafea759015c955fc6e2281b9f/hadoop-hdds/common/src/main/resources/ozone-default.xml#L842-L845
It would be nice to ensure `conf = {...}` is printed in a single log line.
Should we remove such whitespace from the specific properties in
`ozone-default.xml`, or trim values programmatically in
`HddsUtils#processForLogging`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
