sadanand48 commented on PR #4325:
URL: https://github.com/apache/ozone/pull/4325#issuecomment-1448104420
Thanks @adoroszlai for the feedback. Some questions/clarifications:
1. Throwing IllegalArgumentException always prints the command help section,
should we change to throw any other Exception so help message won't print like
OMException("Cannot connect to OM")?
2. Added a check to handle IP address in the latest commit , it will try to
reach the IP and if unreachable throw the error.
3. I think client should be responsible for configuring right OM address in
the config and also currently a warning is thrown if any address cannot be
resolved to inform client about incorrect configuration. One idea is to check
if atleast one of the OM's defined in the config is reachable by doing a
similar check and if not fail.
``` javaif (rpcAddr.isUnresolved()) {
LOG.warn("OzoneManager address {} for serviceID {} remains unresolved
" +
"for node ID {} Check your ozone-site.xml file to ensure ozone
" +
"manager addresses are configured properly.",
rpcAddress, serviceId, nodeId);```
4. Added to RpcClient code now, so this is taken care of.
5. True.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
