smengcl commented on code in PR #4273:
URL: https://github.com/apache/ozone/pull/4273#discussion_r1122456652
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -292,7 +312,8 @@ private void addToObjectIdMap(Table<String, ? extends
WithObjectID> fsTable,
try {
final WithObjectID oldKey = fsTable.get(key);
final WithObjectID newKey = tsTable.get(key);
- if (areKeysEqual(oldKey, newKey)) {
+ if (areKeysEqual(oldKey, newKey) || !isKeyInBucket(key,
tablePrefixes,
Review Comment:
For this PR, you should include the list of other changes in the first PR
comment as well. Such as moving those Managed classes from framework to common,
and the new force full diff config addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
