ayushtkn commented on code in PR #4286:
URL: https://github.com/apache/ozone/pull/4286#discussion_r1122824341
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java:
##########
@@ -484,8 +484,9 @@ private void printStats(PrintStream out) {
out.println("Number of Volumes created: " + numberOfVolumesCreated);
out.println("Number of Buckets created: " + numberOfBucketsCreated);
out.println("Number of Keys added: " + numberOfKeysAdded);
- out.println("Replication: " + replicationConfig.getReplication());
- out.println("Replication type: " + replicationConfig.getReplicationType());
+ if (replicationConfig != null) {
+ out.println("Replication: " + replicationConfig);
+ }
Review Comment:
Do we want to remove ```out.println("Replication type: " +
replicationConfig.getReplicationType());``` in the scope of fixing NPE?
I think we should just fix the NPE. In general changing CLI output is
considered an incompatible change as well. May be if we want to remove it, we
can remove it as part of a separate ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
