xBis7 commented on code in PR #3741:
URL: https://github.com/apache/ozone/pull/3741#discussion_r1123079883
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -116,8 +117,25 @@ public HddsDatanodeService(boolean printBanner, String[]
args) {
this.args = args != null ? Arrays.copyOf(args, args.length) : null;
}
+ private void cleanTmpDir() {
+ if (datanodeStateMachine != null) {
+ MutableVolumeSet volumeSet =
+ datanodeStateMachine.getContainer().getVolumeSet();
+ for (HddsVolume hddsVolume : StorageVolumeUtil.getHddsVolumesList(
Review Comment:
I didn't realize it was casting to `HddsVolume`. You are right, in that
case, it's best to iterate all volumes and check the instance. I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]