szetszwo commented on code in PR #4337:
URL: https://github.com/apache/ozone/pull/4337#discussion_r1125224150
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerController.java:
##########
@@ -196,6 +196,10 @@ public Iterator<Container<?>> getContainers() {
return containerSet.getContainerIterator();
}
+ public Iterable<Container<?>> getContainerSet() {
Review Comment:
We actually should remove `ContainerController.getContainers()` and
`ContainerSet.getContainerIterator()`. They do not follow the Java `Iterable`
interface convention. However, I have not changed it here since the change is
large.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
