smengcl commented on code in PR #4315:
URL: https://github.com/apache/ozone/pull/4315#discussion_r1125258482
##########
hadoop-hdds/rocks-native/src/main/native/Pipe.h:
##########
@@ -0,0 +1,37 @@
+//
+// Created by Swaminathan Balachandran on 3/2/23.
+//
+
+#ifndef UNTITLED_PIPE_H
+#define UNTITLED_PIPE_H
+
+
+#include <stdio.h>
+
+class Pipe {
+ public:
+ Pipe();
+ ~Pipe();
+ void close();
+ int getReadFd() {
+ return p[0];
+ }
+
+ int getWriteFd() {
+ return p[1];
Review Comment:
Define index 0,1,2 rather than throwing those magic numbers around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
