smengcl commented on PR #4348: URL: https://github.com/apache/ozone/pull/4348#issuecomment-1454380942
Thanks @kaijchen for the review. > PS: Can we improve the `Fail: must start with HDDS` message? Doable but not without complicating the checker script. Currently it's just a simple line to strip the string, since the idea is just to ignore the leading `Revert "`. I've added a message to improve clarity, hopefully: ``` ❯ ./dev-support/ci/pr_title_check.sh 'Revert "HDDS-12345. Hello World"' Leading 'Revert "' in the PR title has been stripped solely for this title checking purpose. Performing actual title check on: HDDS-12345. Hello World" OK ❯ ./dev-support/ci/pr_title_check.sh 'HDDS-12345. Hello World' OK ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
