adoroszlai commented on PR #4336: URL: https://github.com/apache/ozone/pull/4336#issuecomment-1456899174
> > > The line numbers do not match the latest code. I guess it was testing the old code? > > Line numbers in TestHSync are off because a01676a9afccf4d7c4c80066d999a087973a9def changed that file on master in the meantime. > a01676a is HDDS-8029 which is BEFORE this commit 3bbb574 The lines added by a01676a were not present in your PR, as it was based on a prior state of `master`: ``` * 3bbb5742c5 HDDS-8024. When readChunk from a datanode fails, retry other datanodes. (#4336) * ... * a01676a9af HDDS-8029. [hsync] Outputstream in encrypted buckets do not return the correct stream capabilities. (#4316) * ... | * 6fa8fc1291 (HDDS-8024-repeat) TEST 10x30x TestHSync,ITestOzoneContractCreate | * 91958b3e0f (HDDS-8024) Fix test failures. | * 67a8b10fdb HDDS-8024. Intermittent inconsistent read in HSync tests. |/ * 84f1523d24 HDDS-7869. Log configuration on component startup. (#4271) ``` Now that the PR has been merged and became 3bbb5742c5f494d940ced1553e5772eecfb6398c on `master`, line numbers are different, due to the presence of a01676a9af. But that doesn't mean I was testing code without the fix. Now I have launched a new run with current `master`: https://github.com/adoroszlai/hadoop-ozone/actions/runs/4347182297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
