SaketaChalamchala commented on PR #4332: URL: https://github.com/apache/ozone/pull/4332#issuecomment-1457167393
Agree with @adoroszlai > 1. Update `hadoop.tags.custom` and `ozone.tags.system` to reflect the list of tags actually in use (combined from XML and annotated classes, i.e. [used.txt](https://github.com/apache/ozone/files/10899778/used.txt)). My understanding is that the both properties should have the same value. `hadoop.tags.custom` is being used to build a `propertyTagsMap` that is used to search properties by available tags. Tags in `ozone.tags.system` are being used to populate configs in SCM and OM UI configuration page. So, it would be better for both of these properties to have all tags in use. Another note here, it would be cleaner if we replace all `DN` tags with `DATANODE` and `S3G` tags with `S3GATEWAY` in `ozone-default.xml`. That way the full list of tags would be `ACL,BALANCER,CLIENT,CONTAINER,CRITICAL,DATANODE,DATASTREAM,DEBUG,DELETION,DEPRECATED,FREON,HA,HDDS,KERBEROS,MANAGEMENT,OM,OPERATION,OZONE,OZONEFS,PERFORMANCE,PIPELINE,RATIS,RECON,REQUIRED,REST,S3GATEWAY,SCM,SECURITY,SERVER,STANDALONE,STORAGE,TLS,TOKEN,UPGRADE,X509`. Please feel free to validate this list. > 2\. Remove the list of tags from the comment, and provide some instructions instead, something like: > ``` > * List of existing tags is defined by the properties `hadoop.tags.custom` and `ozone.tags.system`. > * If you start using a new tag, please update both lists. > ``` One more note, tags in enum in [ConfigTag.java](https://github.com/apache/ozone/blob/master/hadoop-hdds/config/src/main/java/org/apache/hadoop/hdds/conf/ConfigTag.java) are being used in `@Config` annotations. So, it might also be useful to also add another instruction here. ``` * Note: the values are defined in ozone-default.xml by hadoop.tags.custom and ozone.tags.system. * If you start using a new tag, please update both lists in ozone-default.xml as well. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
