adoroszlai opened a new pull request, #4359: URL: https://github.com/apache/ozone/pull/4359
## What changes were proposed in this pull request? Configuration properties can be tagged as a way of grouping (HADOOP-15005). Tags can be used as a filter when browsing config on the web UI. While any string can be used as tag, the web UI only supports a specific set of tags, defined by `ozone.tags.system`. To hook into Hadoop config tagging, the same value needs to be set as `hadoop.tags.custom`. `ozone-default.xml` also lists config tags in a header comment as a hint. Ozone also supports type-safe configuration annotated with `@Config`, which allows tags defined in the enum `ConfigTag`. All these result in [duplication and discrepancies|https://github.com/apache/ozone/pull/4332#pullrequestreview-1319578907] between the various lists of tags. I propose to: 1. use `ConfigTag` as the definitive source 2. remove `ozone.tags.system` and `hadoop.tags.custom` from `ozone-default.xml` 3. replace the header comment in `ozone-default.xml` with a reference to `ConfigTag` https://issues.apache.org/jira/browse/HDDS-8091 ## How was this patch tested? Updated `TestOzoneConfiguration` and `TestOzoneConfigurationFields`. Verified config tags exposed in SCM web UI. Regular CI (in progress): https://github.com/adoroszlai/hadoop-ozone/actions/runs/4352553967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
