[ 
https://issues.apache.org/jira/browse/HDDS-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697580#comment-17697580
 ] 

Ethan Rose edited comment on HDDS-8100 at 3/7/23 6:43 PM:
----------------------------------------------------------

One option is to add a different subcommand {{ozone repair}} that supports 
commands that fix problems with the cluster data. Commands that do repairs can 
be added under here. A few challenges with this:
* We should make sure the node being operated on is in the stopped state. This 
may be challenging since this command runs directly from the client. Some 
solutions:
** Depend on RocksDB locks to fail the command if another process is using the 
DB. This only works for repairs involving RocksDB.
** Add a manual prompt before commands that users must respond to before the 
tool runs. This could look like {{Is the Ozone Manager stopped (y/N)?}}

* There may be code duplication between the debug and repair variants of 
commands, for example if we have {{ozone debug container inspect}} and {{ozone 
repiar container inspect}} that both run the same container inspector code, 
just in different modes.
** This may not end up being a huge issue if we could use inheritance of util 
classes to share the common code among commands.


was (Author: erose):
One option is to add a different subcommand {{ozone repair}} that supports 
commands that fix problems with the cluster data. Commands that do repairs can 
be added under here. A few challenges with this:
* We should make sure the node being operated on is in the stopped state. This 
may be challenging since this command runs directly from the client. Some 
solutions:
** Depend on RocksDB locks to fail the command if another process is using the 
DB. This only works for repairs involving RocksDB.
** Add a manual prompt before commands that users must respond to before the 
tool runs. This could look like {{Is the Ozone Manager stopped (y/N)?}}

> Support repair commands from ozone CLI
> --------------------------------------
>
>                 Key: HDDS-8100
>                 URL: https://issues.apache.org/jira/browse/HDDS-8100
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: Ethan Rose
>            Priority: Major
>
> Currently {{ozone debug}} only offers read-only options. We have had the need 
> for repair tools due to bugs in the past, and it would be good to have a 
> framework and standard practice for adding these repair tools to ozone CLI.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to