Galsza commented on code in PR #4345:
URL: https://github.com/apache/ozone/pull/4345#discussion_r1129507726
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMSecurityProtocolServer.java:
##########
@@ -93,15 +100,22 @@ public class SCMSecurityProtocolServer implements
SCMSecurityProtocol {
private final ProtocolMessageMetrics metrics;
private final StorageContainerManager storageContainerManager;
+ // SecretKey may not be enabled if when neither block token nor container
Review Comment:
typo in comment, you can remove "if"
```suggestion
// SecretKey may not be enabled when neither block token nor container
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMSecurityProtocolServer.java:
##########
@@ -93,15 +100,22 @@ public class SCMSecurityProtocolServer implements
SCMSecurityProtocol {
private final ProtocolMessageMetrics metrics;
private final StorageContainerManager storageContainerManager;
+ // SecretKey may not be enabled if when neither block token nor container
+ // token is enabled.
+ private final SecretKeyManager secretKeyManager;
+
SCMSecurityProtocolServer(OzoneConfiguration conf,
- CertificateServer rootCertificateServer,
- CertificateServer scmCertificateServer,
- X509Certificate rootCACert, StorageContainerManager scm)
+ CertificateServer rootCertificateServer,
Review Comment:
Minor note and hint here: this is an unnecessary indentation change. You can
disable it by editor/codestyle/java -> wrapping and braces tab and disabling
"align when multiline" on method call arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
