Galsza commented on code in PR #4361: URL: https://github.com/apache/ozone/pull/4361#discussion_r1129552399
########## hadoop-ozone/ozonefs-hadoop2/src/main/java/org/apache/hadoop/fs/package-info.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +/** + * Utility classes copied from Hadoop3 to maintain Hadoop2 runtime + * compatibility. + */ [email protected] [email protected] +package org.apache.hadoop.fs; + +import org.apache.hadoop.hdds.annotation.InterfaceAudience; +import org.apache.hadoop.hdds.annotation.InterfaceStability; Review Comment: No new line at the end of file. We should have a checkstyle rule for this point, I'm not sure why this passed. ########## hadoop-ozone/ozonefs-hadoop2/src/main/java/org/apache/hadoop/fs/StreamCapabilities.java: ########## @@ -24,6 +24,11 @@ /** * Interface to query streams for supported capabilities. * + * This is copied from Hadoop3 code to make Ozone compatible with Hadoop2.7 + * runtime dependency. Hadoop 2.7 does not support StreamCapabilities API. + * + * TODO: remove this interface once we drop Hadoop 2.7 support. Review Comment: Could you add a Jira ticket about removing this and also mention it in this TODO for easier tracking? Same for the other message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
