GeorgeJahad commented on PR #4244:
URL: https://github.com/apache/ozone/pull/4244#issuecomment-1460877592
I know we are in a hurry, but snapshot delete is the most complicated and
dangerous part of the snapshot system, so I'd like to see more tests for this
subsystem.
If you are too busy, we can create a separate PR and having someone on my
team write the tests, in particular for the following methods:
private SnapshotInfo getNextActiveSnapshot(SnapshotInfo snapInfo,
private RepeatedOmKeyInfo createRepeatedOmKeyInfo(List<KeyInfo>
keyInfoList)
private void splitRepeatedOmKeyInfo(SnapshotMoveKeyInfos.Builder
toActiveDb,
private SnapshotInfo getPreviousSnapshot(SnapshotInfo snapInfo)
private boolean checkKeyExistInPreviousTable(
In addition, I'd like a unit test that confirms that we are correctly
starting and stopping within the bucket scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
