GeorgeJahad commented on PR #3980: URL: https://github.com/apache/ozone/pull/3980#issuecomment-1461066106
> Can we write some test that can exercise these code paths end to end ? As mentioned above, this integration test does excercise it from end to end: https://github.com/apache/ozone/blob/ed069f01142452dfc59b3f9703e486ef0434d7e4/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java#L151 Most of it already existed already, (to test the existing bootstrapping code from end to end.) I just added a snapshot test to it here: https://github.com/apache/ozone/blob/ed069f01142452dfc59b3f9703e486ef0434d7e4/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMRatisSnapshots.java#L243 I believe it does all of your steps except a configurable number of snapshots. That shouldn't be hard to add. Is it ok if I just make the configuration a parameter in the test file itself? Would that satisfy this request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
