jojochuang commented on code in PR #2466:
URL: https://github.com/apache/ozone/pull/2466#discussion_r1130292903
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/DBCheckpointMetrics.java:
##########
@@ -53,6 +53,11 @@ public static DBCheckpointMetrics create(String parent) {
new DBCheckpointMetrics());
}
+ public void unRegister() {
Review Comment:
is this change related?
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneCluster.java:
##########
@@ -17,13 +17,27 @@
*/
package org.apache.hadoop.ozone;
+import static
org.apache.hadoop.fs.CommonConfigurationKeysPublic.HADOOP_SECURITY_AUTHENTICATION;
Review Comment:
the change in this file is most probably not needed. Unrelated code style
tweak and unused methods.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclUtil.java:
##########
@@ -88,17 +89,18 @@ public static List<OzoneAcl> filterAclList(String
identityName,
return retList;
}
- private static boolean checkAccessInAcl(OzoneAcl a, String[] groups,
- String username, ACLType aclToCheck) {
+ private static boolean checkAccessInAcl(OzoneAcl a, UserGroupInformation ugi,
+ ACLType aclToCheck) {
BitSet rights = a.getAclBitSet();
switch (a.getType()) {
case USER:
- if (a.getName().equals(username)) {
+ if (a.getName().equals(ugi.getShortUserName()) || a.getName()
+ .equals(ugi.getUserName())) {
Review Comment:
I feel like it should stick with getShortUserName() and that it's the caller
who creates the OzoneAcl objects should make sure it passes in short user names.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/MiniOzoneCluster.java:
##########
@@ -654,9 +658,32 @@ public Builder setDnLayoutVersion(int layoutVersion) {
* Constructs and returns MiniOzoneCluster.
*
* @return {@link MiniOzoneCluster}
- *
* @throws IOException
*/
public abstract MiniOzoneCluster build() throws IOException;
}
+
+ static void setupKerberosConfiguration(Configuration conf,
Review Comment:
This is not used anywhere. Is this needed?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java:
##########
@@ -1309,6 +1309,9 @@ public void incEcBucketCreateFailsTotal() {
}
public void unRegister() {
+ if (dbCheckpointMetrics != null) {
Review Comment:
is this change related?
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/volume/ListVolumeHandler.java:
##########
@@ -72,7 +72,7 @@ protected void execute(OzoneClient client, OzoneAddress
address)
throws IOException {
if (userName == null) {
- userName = UserGroupInformation.getCurrentUser().getUserName();
+ userName = UserGroupInformation.getCurrentUser().getShortUserName();
Review Comment:
This'll most likely break HDDS-7920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
