hemantk-12 commented on code in PR #4360:
URL: https://github.com/apache/ozone/pull/4360#discussion_r1130434301


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -67,21 +77,74 @@ public final class OmSnapshotManager implements 
AutoCloseable {
   private final OzoneManager ozoneManager;
   private final SnapshotDiffManager snapshotDiffManager;
   private final LoadingCache<String, OmSnapshot> snapshotCache;
-  private final ManagedRocksDB snapshotDiffDb;
+  private ManagedRocksDB snapshotDiffDb;
+
+  /**
+   * Contains all the snap diff job which are either queued, in_progress or
+   * done. This table is used to make sure that there is only single job for

Review Comment:
   It would be time based (keep the diff report for 7 days) or status based 
(Failed or Rejected).



##########
hadoop-hdds/test-utils/src/main/java/org/apache/ozone/test/GenericTestUtils.java:
##########
@@ -293,6 +293,21 @@ public static <K, V> Map<V, K> getReverseMap(Map<K, 
List<V>> map) {
             .collect(Collectors.toMap(Pair::getKey, Pair::getValue));
   }
 
+  /***
+   * Removed all files and dirs in the given dir recursively.
+   */
+  public static boolean deleteDirectory(File dir) {
+    File[] allContents = dir.listFiles();

Review Comment:
   No, it reads all the file and dir in path and deletes them recursively.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to