dombizita opened a new pull request, #4369:
URL: https://github.com/apache/ozone/pull/4369

   ## What changes were proposed in this pull request?
   
   previous this change the `DatanodeDetails` didn't store any information 
regarding the HTTP and HTTPS ports of the datanode. there was a 
[conversation](https://github.com/apache/ozone/pull/4278#issuecomment-1439184020)
 on how to add the ports in a backward compatible way and we decided to add a 
new HDDS layout version as `WEBUI_PORTS_IN_DATANODEDETAILS`. I created a 
`BelongsToHDDSLayoutVersion` annotation and used it to annotate the new HTTP 
and HTTPS ports with the new layout version. in the `getDatanodeDetailsYaml` 
when we are adding the ports I checked if the port has this annotation and 
checked if the current layout version is smaller than the layout version of 
`WEBUI_PORTS_IN_DATANODEDETAILS` and in that case I am not writing the ports in 
to the `DatanodeDetails` yaml file.
   
   I needed to change the MLV in of the compat tests as the latest one is 5 
now. also as not the `DATANODE_SCHEMA_V3` is the latest HDDS layout version 
anymore I changed some tests to not require exact match with the versions in 
the `TestDatanodeUpgradeToSchemaV3.java`.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7817
   
   ## How was this patch tested?
   
   green CI on my fork: 
https://github.com/dombizita/ozone/actions/runs/4369081456/jobs/7650370829
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to