ArafatKhan2198 commented on code in PR #4182:
URL: https://github.com/apache/ozone/pull/4182#discussion_r1131955546
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -170,11 +170,18 @@ public Response getKeysForContainer(
for (ContainerKeyPrefix containerKeyPrefix : containerKeyPrefixMap
.keySet()) {
- // Directly calling get() on the Key table instead of iterating since
- // only full keys are supported now. When we change to using a prefix
- // of the key, this needs to change to prefix seek.
- OmKeyInfo omKeyInfo = omMetadataManager.getKeyTable(getBucketLayout())
+ // Directly calling getSkipCache() on the Key/FileTable table
+ // instead of iterating since only full keys are supported now. We will
+ // try to get the OmKeyInfo object by searching the KEY_TABLE table
with
+ // the key prefix. If it's not found, we will then search the
FILE_TABLE
+ OmKeyInfo omKeyInfo =
omMetadataManager.getKeyTable(BucketLayout.LEGACY)
Review Comment:
Thank you for bringing this to my attention. I understand that directory
keys won't be considered in the case of FSO, but as you rightly pointed out,
since the endpoint name is "getKeysForContainers" and we are concerned only
with the keys that carry data size, I believe these change is still relevant
and helpful for debugging purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
