kerneltime commented on code in PR #4367:
URL: https://github.com/apache/ozone/pull/4367#discussion_r1132777148


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java:
##########
@@ -159,6 +160,26 @@ public static void removeContainer(KeyValueContainerData 
containerData,
     FileUtils.deleteDirectory(containerMetaDataPath.getParentFile());
   }
 
+  /**
+   * Returns if there are no blocks in the container.
+   * @param containerData Container to check
+   * @param conf configuration
+   * @return true if the directory containing blocks is empty
+   * @throws IOException
+   */
+  public static boolean noBlocksInContainer(KeyValueContainerData

Review Comment:
   The likelihood of having blocks written to disk but not in DN RocksDB will 
go down with https://issues.apache.org/jira/browse/HDDS-8117
   We will still have the issue of having blocks on DN that are not on OM which 
needs to be dealt with separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to