smengcl commented on PR #4315: URL: https://github.com/apache/ozone/pull/4315#issuecomment-1464560676
Thanks @swamirishi for the patch. It is a huge effort to put this all together. Thanks @adoroszlai @prashantpogde for the code review. > if there are any special build parameters you have in mind for building this like the native library compile for hadoop? ie. `$ mvn package -Pdist,native -DskipTests -Dtar` Hi @neils-dev , the extra maven parameter has been included in the PR description now, namely `-Drocks_tools_native`. @kerneltime w.r.t. to the build time concern, as tested [above](https://github.com/apache/ozone/pull/4315#issuecomment-1464381647), by default it will not impact the build time. Adding `-Drocks_tools_native` to trigger the RocksDB tool compilation adds another ~1.5 min to the total build time (M1 Pro MBP), which is not required for most other dev work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
