neils-dev commented on code in PR #3741: URL: https://github.com/apache/ozone/pull/3741#discussion_r1133006661
########## hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/TestHddsDatanodeService.java: ########## @@ -48,10 +48,7 @@ import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_CONTAINER_TOKEN_ENABLED; import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_SECURITY_ENABLED_KEY; import static org.apache.hadoop.ozone.OzoneConsts.OZONE_URI_DELIMITER; -import static org.junit.jupiter.api.Assertions.assertFalse; Review Comment: Having the Junit 5 assert methods fully qualified is fine. We can leave them in the file and prevent unneeded changes having to be merged. We can leave the fully qualified imports for `assertFalse`, `assertTrue`, `assertNotNull`, `assertNull `and revert the changes in the file due to their omission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
