GeorgeJahad commented on code in PR #4182:
URL: https://github.com/apache/ozone/pull/4182#discussion_r1134795450
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -397,7 +419,81 @@ private List<ContainerBlockMetadata> getBlocks(
return blockIds;
}
- private BucketLayout getBucketLayout() {
- return BucketLayout.DEFAULT;
+ /**
+ * Builds an object path for a file system optimized bucket.
+ *
+ * @param prevKeyPrefix the previous key prefix of the object path
+ * @return the object path for the file system optimized bucket
+ * @throws IOException if an IO error occurs
+ */
+ private String buildObjectPathForFileSystemBucket(String prevKeyPrefix)
Review Comment:
I don't see this method being tested anywhere. Am I missing it.
Also the name sounds awkward because it sounds like it is only return fso
paths. I would probably just call it correctPathForLayout() or something like
that.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ContainerEndpoint.java:
##########
@@ -397,7 +419,81 @@ private List<ContainerBlockMetadata> getBlocks(
return blockIds;
}
- private BucketLayout getBucketLayout() {
- return BucketLayout.DEFAULT;
+ /**
+ * Builds an object path for a file system optimized bucket.
+ *
+ * @param prevKeyPrefix the previous key prefix of the object path
+ * @return the object path for the file system optimized bucket
+ * @throws IOException if an IO error occurs
+ */
+ private String buildObjectPathForFileSystemBucket(String prevKeyPrefix)
Review Comment:
I don't see this method being tested anywhere. Am I missing it?
Also the name sounds awkward because it sounds like it is only return fso
paths. I would probably just call it correctPathForLayout() or something like
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
