smengcl commented on code in PR #4244:
URL: https://github.com/apache/ozone/pull/4244#discussion_r1135015127
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/WithObjectID.java:
##########
@@ -61,10 +61,6 @@ public long getUpdateID() {
* @param obId - long
*/
public void setObjectID(long obId) {
- if (this.objectID != 0) {
Review Comment:
Or adjust the condition to make `obId` equals `OBJECT_ID_DEFAULT` the only
exception:
```
if (this.objectID != 0L && obId != OBJECT_ID_DEFAULT) {
```
To avoid other methods from potentially abusing this before we do the proper
OmKeyInfo field addition (so we can flip it back).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
