hemantk-12 commented on PR #4360: URL: https://github.com/apache/ozone/pull/4360#issuecomment-1469132124
> Thanks @hemantk-12 for this PR. Good core code comments. Nice optimization. Thanks for the UT refactoring. > > Some minor comments inline. > > Q: Are new UTs going to be added in the follow-up PR when we actually switch to async SnapDiff with pagination? Thanks for the review @smengcl. > Q: Are new UTs going to be added in the follow-up PR when we actually switch to async SnapDiff with pagination? Yes, I'll add unit tests either in next PR or as a separate PR depending upon the size of new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
