adoroszlai commented on code in PR #4373:
URL: https://github.com/apache/ozone/pull/4373#discussion_r1137407337
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemMetrics.java:
##########
@@ -81,9 +84,10 @@ public static void init() throws Exception {
.setStreamBufferMaxSize(4) // MB
.build();
cluster.waitForClusterToBeReady();
+ client = cluster.getClient();
// create a volume and a bucket to be used by OzoneFileSystem
- bucket = TestDataUtil.createVolumeAndBucket(cluster);
+ bucket = TestDataUtil.createVolumeAndBucket(client);
Review Comment:
Most callers reuse `client` for other operations. Previously they passed
`cluster`.
This class is already bloated considering how little it does (too many
overloads of the same functionality), so adding a no-client version, for the
few instances where we don't need the client for anything else, doesn't seem
worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
