hemantk-12 commented on code in PR #4376:
URL: https://github.com/apache/ozone/pull/4376#discussion_r1139404653
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java:
##########
@@ -800,4 +802,12 @@ public static Map<String, String>
processForLogging(OzoneConfiguration conf) {
}
return sortedOzoneProps;
}
+
+ /**
+ * Interface for Implementing CloseableIterators.
+ * @param <T> Generic Parameter for Iterating values of type 'T'
+ */
+ public interface CloseableIterator<T> extends Iterator<T>, Closeable {
Review Comment:
~I think it is unnecessary interface. You can directly implement `Iterator`
and `Closeable` wherever is needed.~
~If you think it is really needed, it doesn't have to be in Util class.~
I see why it has to be this way. But I think it deserves its own class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
