smengcl commented on code in PR #4398:
URL: https://github.com/apache/ozone/pull/4398#discussion_r1140909511
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/ObjectStore.java:
##########
@@ -569,6 +569,7 @@ public List<OzoneSnapshot> listSnapshot(String volumeName,
String bucketName)
* @param toSnapshot The name of the ending snapshot
* @param token to get the index to return diff report from.
* @param pageSize maximum entries returned to the report.
+ * @param forceFullDiff show full diff without using the optimised DAG method
Review Comment:
nit
```suggestion
* @param forceFullDiff request to force full diff, skipping DAG
optimization
```
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java:
##########
@@ -705,6 +705,7 @@ default List<SnapshotInfo> listSnapshot(String volumeName,
String bucketName)
* @param toSnapshot The name of the ending snapshot
* @param token to get the index to return diff report from.
* @param pageSize maximum entries returned to the report.
+ * @param forceFullDiff perform full diff without using optimized DAG
approach
Review Comment:
```suggestion
* @param forceFullDiff request to force full diff, skipping DAG
optimization
```
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ClientProtocol.java:
##########
@@ -1059,11 +1059,13 @@ List<OzoneSnapshot> listSnapshot(String volumeName,
String bucketName)
* @param toSnapshot The name of the ending snapshot
* @param token to get the index to return diff report from.
* @param pageSize maximum entries returned to the report.
+ * @param forceFullDiff show full diff without using the optimised DAG method
Review Comment:
```suggestion
* @param forceFullDiff request to force full diff, skipping DAG
optimization
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
