xBis7 commented on PR #4421: URL: https://github.com/apache/ozone/pull/4421#issuecomment-1476226169
@mohan3d FairCallQueue has multiple priority queues (4 by default) and requests are placed into those queues based on their priorities. `DecayRpcScheduler` calculates the priority of a call and then the call goes into the queue with the corresponding priority (for instance, highest priority call will go into the queue with the highest priority). Your approach simulates the behavior of `backoff` but with `backoff` in order to reject a request all queues must be full. Check [here](https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/FairCallQueue.html). Let's say we have only 1 user and max requests is set to 10000. If the user exceeds that number of requests then your filter will start rejecting all new requests coming from that user while it shouldn't since he is the only one stressing the system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
