adoroszlai commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1144014914
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh:
##########
@@ -70,7 +70,7 @@ with_old_version_downgraded() {
}
with_new_version_finalized() {
- _check_hdds_mlvs 4
+ _check_hdds_mlvs 5
Review Comment:
In offline discussion with @dombizita and @fapifta we agreed that the 1.4.0
upgrade test should be added separately, before this PR. Thanks @errose28 for
the info on your work related to that.
Also, ideally this PR should be split into two:
* adding the framework to handle new ports, and applying it to
RATIS_DATASTREAM
* adding the new HTTP ports
each with a new layout version, and bumping expected version after
finalization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]