ChenSammi commented on code in PR #4439:
URL: https://github.com/apache/ozone/pull/4439#discussion_r1144220126
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/acl/OzoneNativeAuthorizer.java:
##########
@@ -104,34 +106,45 @@ public boolean checkAccess(IOzoneObj ozObject,
RequestContext context)
// Refined the parent context
// OP |CHILD |PARENT
- // CREATE NONE WRITE (parent:'CREATE' when 'create
bucket')
- // DELETE DELETE WRITE
- // WRITE WRITE WRITE
- // WRITE_ACL WRITE_ACL WRITE (V1 WRITE_ACL=>WRITE)
+ // CREATE NONE WRITE (parent:'CREATE' when 'create bucket')
Review Comment:
Please move this parent ACL logic and comments into a separate function,
then both OzoneNativeAuthorizer and OzoneAclUtil can leverage it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
